The letter S in a light blue, stylized speech bubble followed by SpeakBits
SpeakBitsThe letter S in a light blue, stylized speech bubble followed by SpeakBits
Trending
Top
New
Controversial
Search
Groups

Enjoying SpeakBits?

Support the development of it by donating to Patreon or Ko-Fi.
About
Rules
Terms
Privacy
EULA
Cookies
Blog
Have feedback? We'd love to hear it!

Exactly what to say in code reviews

highgrowthengineer.com
submitted
a year ago
byjustadevtoprogramming

Summary

In the past, I gave feedback which slowly built tension throughout the review. My teammates were defensive, and I was at fault. After learning a few tricks, I never ran into the same issues. This article will give you 7 simple techniques to give feedback in code reviews.

Stop using “why” wherever possible and replace it with “what” “Why” triggers defensiveness which can be avoided with ‘what’ “Can we’ is a good option if you are fairly certain it’s the right thing to do.

“I wonder…” - Use it to suggest lightly while opening it up for discussion. “I’m curious…’ - Use It to call out something that may not be great about the current approach. � “What > why” – Use “what” instead of “why” wherever possible.

 comic book book jacket dust cover dust jacket dust wrapper cellular telephone cellular phone cellphone cell mobile phone web site website internet site site-0
14

5 Comments

8
kaiserseahorse
a year ago
I gotta say this came at just the right time! I've started having to review PRs from more junior devs and I want to make sure I come off helpful and not like an ass
3
justadevOP
a year ago
It's definitely made me rethink how I write things!
5
splitsecond
a year ago
Sounds like this would be hard to effectively do as you're trying to cognitively change what you're trying to say at all times
4
justadevOP
a year ago
Might be a bit tough for some people to do. I've seen some recommendations to try and preemptively establish the tone of your message, with either tags or a small message to start
1
splitsecond
a year ago
That's actually pretty cool to do! Just a little warning if it's meant to be mean or not! Might have to try this